Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG-1409 reset default sort bug #1306

Merged

Conversation

sagely1
Copy link
Contributor

@sagely1 sagely1 commented May 13, 2024

Bug in sorting direction when switching categories.

@sagely1 sagely1 requested a review from hallieswan May 13, 2024 22:21
Copy link
Contributor

@hallieswan hallieswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! A couple suggestions for how to use the constants and helper methods added in #1304, if you'd like

tests/gene-comparison-tool.spec.ts Outdated Show resolved Hide resolved
tests/gene-comparison-tool.spec.ts Outdated Show resolved Hide resolved
tests/gene-comparison-tool.spec.ts Outdated Show resolved Hide resolved
tests/gene-comparison-tool.spec.ts Outdated Show resolved Hide resolved
tests/gene-comparison-tool.spec.ts Outdated Show resolved Hide resolved
tests/gene-comparison-tool.spec.ts Outdated Show resolved Hide resolved
@sagely1 sagely1 merged commit 9cb9f79 into Sage-Bionetworks:develop May 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants